Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record reason in KilledByHttp2ThreadPoolManager #82

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Aug 25, 2023

This is the first patch of a series of three patches; this first patch is primarily preparatory: it records the reason a server handler is killed as part of the KilledByHttp2ThreadPoolManager. This primarily helps debugging, but it can also serve some other functions; more on that in the next patch.

This was referenced Aug 25, 2023
@kazu-yamamoto kazu-yamamoto self-requested a review August 28, 2023 01:00
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit f8bbddc into kazu-yamamoto:master Aug 28, 2023
10 checks passed
@kazu-yamamoto
Copy link
Owner

Merged. Thanks!

@edsko edsko deleted the edsko/KilledByHttp2ThreadPoolManager-reason branch August 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants