-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client sync threads #89
Conversation
Background: |
Yes, I'm back as of Monday evening (Wednesday morning now). I should have time to look at these today or tomorrow! You'll hear from me very soon :) Thanks :) |
@kazu-yamamoto It seems that this doesn't solve the problem, when I remove my |
Ok, I looked at the Wireshark output. If I do not use my |
3f46606
to
94948b3
Compare
Uhhm. |
Ok, perhaps that's my side then. I will dig. |
OK. I understand. |
I hope that 287e8f6 fixes your problem. |
@kazu-yamamoto Well, good sir, I think you got it! The problem is non-deterministic so I can't be 100% sure, but I have one regression test which for whatever reason seemed to trigger it quite reliably; I ran it over and over again for about 10 minutes and every single run passed; then I ran my full QuickCheck-based test suite for 50 minutes and it also passed. Nice work! |
Merged. Are there any issues before the next major release? |
None that I am currently aware of! There might be some memory leaks, I haven't gotten to the stress testing part of my library yet, but there are, they should not affect the API. |
This should fix #87.