Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exporting LogStr #184

Closed
MichaelXavier opened this issue Jan 22, 2020 · 1 comment
Closed

Consider exporting LogStr #184

MichaelXavier opened this issue Jan 22, 2020 · 1 comment

Comments

@MichaelXavier
Copy link
Contributor

I frequently work with libraries that expose their logging API via LogStr, e.g. persistent. I would like to route these log messages to a different logging system but LogStr does not export sufficient constructors to do so. I was wondering if you'd be open to creating an Internal module tree and exporting basically what you've got in System.Log.FastLogger.LogStr right now. I'd even say you could just rename that module. This would of course carry the caveat that the API can break any time under the Internal module.

As it stands right now, for every log message I will have to show it to convert it from a builder to a string, then convert that back into the same exact Builder type for my log sink.

@kazu-yamamoto
Copy link
Owner

Yes. Internal makes sense to me. Would you send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants