-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some helpers #84
Comments
B.T.W, is there any reason not to update date-cache package with auto-update implementation? |
Please give us pull request to show your code. Michael maintains monad-logger while I maintain fast-logger and wai-logger. Please separate your pull requests for each maintainer. If you mix up, the review process gets harder. |
date-cache is obsoleted. Warp has date cache by itself now. |
A side note: should we make a global simpleTimeCacher? My preference is not but I really need some input here. |
Does the global time cacher stay always even in the case where date is not necessary? |
That depend on how auto-update implement cache, from what i read from yesodweb/wai#351, cacher will be auto turned off if user don't read it frequently enough. |
Yes, you are right. |
Ok, i will add a global |
I'd like to add following enhancements:
ApacheLoggerActions
from wai-logger to something likeFastLoggerActions
with configurable auto-rotate and auto-log-timestamp capabilities, add these to fast-logger.Motivation: timestamp logging is absolutely necessary, a lot of librarys doing this in a very inefficient way, for example, logging doing this with a system call and a directly
show
. The work you have done in wai-logger is awesome!runFastLoggerLoggingT :: MonadIO m => FastLoggerActions -> LoggingT m a -> m a
to monad-logger and re-exportFastLoggerActions
related functions from fast-logger.Motivation: since monad-logger rely on fast-logger, we should provide ways to use it with
MonadLogger
.Are these changes look good to you? I'd like send a pr with those enhancement : )
The text was updated successfully, but these errors were encountered: