Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for monad-control-1.0.0.0 #52

Merged
merged 2 commits into from Dec 15, 2014

Conversation

@RyanGlScott
Copy link
Contributor

commented Dec 15, 2014

Fix monad-logger to use monad-control-1.0.0.0 or later, which uses associated type synonyms instead of associated data for MonadTransControl and MonadBaseControl.

@snoyberg

This comment has been minimized.

Copy link
Collaborator

commented Dec 15, 2014

Thank you for the pull request. Would it be possible to make the changes conditional on the version of monad-control being used, so that the codebase continues to function with both the old and new monad-control?

@RyanGlScott

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2014

There, I used CPP pragmas to select the proper code depending on the version of monad-control being used.

@snoyberg snoyberg merged commit 5321818 into kazu-yamamoto:master Dec 15, 2014
@snoyberg

This comment has been minimized.

Copy link
Collaborator

commented Dec 15, 2014

Thank you very much for both patches!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.