Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for monad-control-1.0.0.0 #52

Merged
merged 2 commits into from Dec 15, 2014
Merged

Fix for monad-control-1.0.0.0 #52

merged 2 commits into from Dec 15, 2014

Conversation

RyanGlScott
Copy link
Contributor

Fix monad-logger to use monad-control-1.0.0.0 or later, which uses associated type synonyms instead of associated data for MonadTransControl and MonadBaseControl.

@snoyberg
Copy link
Collaborator

Thank you for the pull request. Would it be possible to make the changes conditional on the version of monad-control being used, so that the codebase continues to function with both the old and new monad-control?

@RyanGlScott
Copy link
Contributor Author

There, I used CPP pragmas to select the proper code depending on the version of monad-control being used.

@snoyberg snoyberg merged commit 5321818 into kazu-yamamoto:master Dec 15, 2014
@snoyberg
Copy link
Collaborator

Thank you very much for both patches!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants