New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showable logging functions #78
Conversation
|
||
-- | Generates a function that takes a 'Show a => a' and logs a 'LevelDebug' message. Usage: | ||
-- | ||
-- > $(logDebug) "This is a debug log message" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add @since
comments and do a minor version bump in the cabal file/changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this is satisfactory please :)
-- | ||
-- > $(logOtherSH "My new level") "This is a log message" | ||
logOtherSH :: Text -> Q Exp | ||
logOtherSH = logTH . LevelOther |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be logTHShow
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh, yes, good catch. Fixed. Sorry about that :\
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP, that's what code review is for :)
Thanks! |
Used SH for SHowable. Hopefully this is good enough.