State-based property test for RxFlow. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
GHC 9.6.4 is provided with |
|
Can you use |
test/Network/Control/FlowSpec.hs
Outdated
|
|
||
| -- types | ||
|
|
||
| deriving instance Eq RxFlow |
There was a problem hiding this comment.
I added Eq for RxFlow on main.
So, please remove this line.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code fell out of our attempts to debug http2, and even though they didn't reveal any bugs, I think they are useful as documentation.
It's also good to have a test suite to encourage people to contribute to it. :-)
Let me know if you want to have this, but need me to change or add anything.
Thanks!