fix recvStream hanging #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazu-yamamoto
requested changes
May 10, 2023
|
I added two tests, simulating both cases that client/server stop the stream first. Here client or server stop the stream by first sending STOP_SENDING followed by RESET_STREAM. This is how Chrome performs stream closing while keeping connection opened. Without the fix, both test will fail (hang indefinitely). |
If `RESET_STREAM` frame arrives after `recvStream` started pulling from `RecvStreamQ` (`takeRecvStreamQ` call in `takeRecvStreamQwithSize`), `recvStream` will hang indefinitely (until being killed by thread manager). Fix this by pushing a pseudo FIN (empty bytestring) to `RecvStreamQ`. Also add two test to ensure recvStream don't block in the cases that server or client stop the stream. Without this fix, both tests failed.
|
Rebased and merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
RESET_STREAMframe arrives afterrecvStreamstarted pulling fromRecvStreamQ(takeRecvStreamQcall intakeRecvStreamQwithSize),recvStreamwill hang indefinitely (until being killed by thread manager).Fix this by pushing a pseudo FIN (empty bytestring) to
RecvStreamQ.