Underline is not visible anymore, see example code for simple!

[HomanF]

No description provided.

[kazuhiro4949]

I'm soooo sorry!

[HomanF]

No problem :)

Also I have problem with the content inset to add padding from 1.2.0, it won't change the padding, any ideas why?

What I'm trying to do is when I have 3 menus/title I want it to be center but at the same time resize the underline to fit the text width, how could I manage that?

[kazuhiro4949]

I'll check the padding problem later.

You can change PagingMenuViewController.view.bounds.width on storyboard or view controller.
https://github.com/kazuhiro4949/PagingKit/blob/master/README.md#1-put-container-views-on-storyboard

It is one of the way to change the menu layout.

1. Set a x axis constraint to PagingMenuViewController's container view in Storyboard.
2. Set a width constraint to PagingMenuViewController's container view in Storyboard.
3. Add IBOutlet of width constraint to your view controller.

http://blog.ijasoneverett.com/2014/02/resize-uitableview-height-with-auto-layout/
http://www.iosinsight.com/access-storyboard-and-xib-constraints-in-code/

You can set any width according to the number of item.
Please try :)

[kazuhiro4949]

I released v1.2.1

https://github.com/kazuhiro4949/PagingKit/releases/tag/1.2.1

[HomanF]

Great thanks alot :) I noticed also for editing underline height in UnderlineFocusView class, your forgot to add the var to the private func setup. Now its attribute: .height, multiplier: 1, constant: 4)) It should be attribute: .height, multiplier: 1, constant: underlineHeight)) And how do I access this var from my vc to change it? Regards Homan

…

On 5 Jan 2018, at 02:55, Kazuhiro Hayashi ***@***.***> wrote: I released 1.2.1 https://github.com/kazuhiro4949/PagingKit/releases/tag/1.2.1 <https://github.com/kazuhiro4949/PagingKit/releases/tag/1.2.1> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGy-vIty12f1-dvIu4kWf8Twg_HugMRPks5tHYD2gaJpZM4RTZlc>.

[kazuhiro4949]

I'd clean forgotten underlineHeight :p
I'll fix it toooo.

[kazuhiro4949]

I released 1.2.2
https://github.com/kazuhiro4949/PagingKit/releases/tag/1.2.2

[kazuhiro4949]

And how do I access this var from my vc to change it?

You can set a value to the property with v1.2.2.

let focusView = UnderlineFocusView()
focusView.underlineHeight = 10
menuViewController?.registerFocusView(view: focusView)

[HomanF]

great thanks alot :) but same goes for underlineColor there is no didSet! sorry

should be:

public var underlineColor = UIColor.pk.focusRed {
didSet {
    underlineView.backgroundColor = underlineColor
    }
}

[HomanF]

Same goes for TitleLabelMenuViewCell, should be:

/// The text color when selecred
public var focusColor = UIColor.pk.focusRed {
didSet {
titleLabel.textColor = focusColor
}
}

/// The normal text color.
public var normalColor = UIColor.black {
    didSet {
        titleLabel.textColor = normalColor
    }
}

[kazuhiro4949]

Thanks a lot lol.
I'll fix them later.

TitleLabelMenuViewCell object is reused in PagingMenuView again and again because of the architecture.
So I'll change the style properties to class variable.

[kazuhiro4949]

@HomanF
I decided to add "didSet" as you mentioned.
TitleLabelMenuViewCell's property assumes to be set on cellForItemAt.

    func menuViewController(viewController: PagingMenuViewController, cellForItemAt index: Int) -> PagingMenuViewCell {
        let cell = viewController.dequeueReusableCell(withReuseIdentifier: "identifier", for: index)  as! TitleLabelMenuViewCell
        cell.focusColor = .blue
        cell.normalColor = .red
        cell.isSelected = (viewController.currentFocusedIndex == index)
        cell.titleLabel.text = dataSource[index].menu
        return cell
    }

[kazuhiro4949]

@HomanF
I fixed the problems (except for padding).
Thank you for your contribution :)

[kazuhiro4949]

I added cellAlignment feature in 1.3.0. So you can cells in the center.
https://github.com/kazuhiro4949/PagingKit/releases/tag/1.3.0
https://github.com/kazuhiro4949/PagingKit#cell-alignment

What I'm trying to do is when I have 3 menus/title I want it to be center but at the same time resize the underline to fit the text width, how could I manage that?