Topic/parallel cleanup #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, is there anything I can do to assist? |
|
rebased against the latest master |
|
Thank you for the fix. Cherry-picked to master in commit 6e5e772 and released as 0.05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few times a week on some of my PSGI servers running 50-100 simultaneous workers, I get this type of error:
Parallel::Scoreboard:130 - failed to remove an obsolete scoreboard file:server-status/status_27543:No such file or directory at /home/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Parallel/Scoreboard.pm line 130.
This seems to be caused by two workers being queried for /server-status (by way of Plack::Middleware::ServerStatus::Lite, which uses Parallel::Scoreboard) at the same time, causing two processes to call read_all() at the same time. One of the processes cleans up an obsolete file after the other process calls glob(), but before it calls unlink(), generating an ENOENT error.
This patch checks for that type of error before warning.