Resolve real absolute path if prog path is a symbolic link in _get_path_of
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath_of` Bacause, `$mysql_basedir` resolving fail if mysql_install_db is a symbolic link.
|
Thank you for the fix! squash-merged to master at commit f00337e. |
|
Thank you for the fix! Squash-merged to master at commit f00337e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implement,
$mysql_basedirresolving possibly fail if mysql_install_dbis a symbolic link.
In my case, I'm using MySQL 5.6.10 homebrew installed in OSX upgraded from
5.5.28 and
which mysql_install_dbreturns '/usr/local/bin/mysql_install_db',but this is a symlink to '../Cellar/mysql/5.6.10/bin/mysql_install_db',
and
$mysql_basedirresolving will fail.Then I wrote this patch, but I have not so confident if is this patch appropriate or not.