do not consume extra char when parsing a scalar number #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
added a commit
that referenced
this pull request
Feb 29, 2016
do not consume extra char when parsing a scalar number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
class inputincrements the input iterator whengetc()is called. Therefore, whenungetc()is called laterwards and then if the parse function returns, the iterator will point at next to the end position of JSON.note: this becomes an issue only when the input is a scalar number; to parse JSON input (number) like:
123abc, the parser needs to reada, callungetc(), and then returnThis PR fixes the issue by delaying the moment when the iterator gets incremented, until to when the next character is fetched by the parser.