Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified file in dist folder #34

Closed
pvnr0082t opened this issue May 31, 2016 · 6 comments
Closed

Minified file in dist folder #34

pvnr0082t opened this issue May 31, 2016 · 6 comments

Comments

@pvnr0082t
Copy link

vue & vue-i18n version

All versions of vue-i18n

What is Expected?

We are cdnjs team. We want to host vue-i18n.
I found that vue-i18n.js in dist folder has been minified but vue-i18n.common.js does not.
The auto-updater in cdnjs doesn't support partial minification, so in this case, we should manually minify vue-i18n.common.js file.

I'll respectfully suggest you consider to provide vue-i18n.common.min.js in dist folder so that auto-updater in cdnjs can work well. Thanks.

cdnjs/cdnjs#7894

@kazupon
Copy link
Owner

kazupon commented Jun 1, 2016

There is already vue-i18n.min.js as minified file in dist.
Can we update the automatically for vue-i18n.min.js?

@pvnr0082t
Copy link
Author

pvnr0082t commented Jun 1, 2016

So the vue-i18n.common.min.js don't need to be added in cdnjs? Or you mean we only need to host vue-i18n.min.js?

@kazupon
Copy link
Owner

kazupon commented Jun 3, 2016

Yes!, That would be great :)

@pvnr0082t
Copy link
Author

Hi @kazupon ,
I would like to confirm that all files in dist folder need to be hosted and there is vue-i18n.min.js as minified file so we don't need to minify vue-i18n.common.js. Could you please check if it is correct? Thank you.

@kazupon
Copy link
Owner

kazupon commented Jun 7, 2016

Yes.
There is vue-i18n.min.js as minified file in dist.
vue-i18n.common.js is provided for CommonJS.

@pvnr0082t
Copy link
Author

Okay, thanks for your help! 👍

@kazupon kazupon closed this as completed Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants