-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vue-i18n@4.0.1 w/ npm autoupdate #8150
Conversation
@pvnr0082t |
@kennynaoh I have rebased on the latest master branch. Please help me review again, thank you. |
@PeterDaveHello |
What's the reason why to drop |
@PeterDaveHello |
I didn't see any comment to mention the reason. |
@PeterDaveHello Author said that there is |
@pvnr0082t You asked about the minified common file, not the origin one. Anyway, please confirm that, I did not see a reason of not hosting it, since it's in dist folder, it's odd not to host it. |
@kennynaoh I have confirm with author again kazupon/vue-i18n#34. And the latest version is v4.0.1. Please help me review again, thank you. |
@PeterDaveHello |
What's the reqason why not to minify |
I thought the author had said that we don't need to minify |
@kennynaoh We should minify it. |
@kennynaoh I have minified |
@PeterDaveHello |
@pvnr0082t @kennynaoh please use a shorter title/first line commit next time, I'll modify the commit this time. |
PR for #7894
@kennynaoh Please help me review this pull request, thank you.
Here is an issue discuss with author about files to get in dist folder.
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist
close #7894, cc @kazupon