Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(index): Fix #193 add availableLocales #528

Merged
merged 7 commits into from
Mar 8, 2019
Merged

feat(index): Fix #193 add availableLocales #528

merged 7 commits into from
Mar 8, 2019

Conversation

exoego
Copy link
Collaborator

@exoego exoego commented Mar 7, 2019

Closes #193

kazupon
kazupon requested changes Mar 7, 2019
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
I've reviewed this PR 👀

I have a request. 🙏
Could you add documentation, please?

src/index.js Outdated Show resolved Hide resolved
@kazupon
Copy link
Owner

kazupon commented Mar 7, 2019

and, in addition, I have one more request.
Could you add type declaration of typescript and flow, please? 🙏

@kazupon @exoego
Update src/index.js
c6f7918 
Co-Authored-By: exoego <ytatsuno.jp@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #528 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #528      +/-   ##
==========================================
+ Coverage   96.63%   96.63%   +<.01%     
==========================================
  Files           9        9              
  Lines         683      684       +1     
==========================================
+ Hits          660      661       +1     
  Misses         23       23
Impacted Files Coverage Δ
src/index.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396c5ca...c6f7918. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019 •
edited
Loading

Codecov Report

Merging #528 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #528      +/-   ##
==========================================
+ Coverage   96.63%   96.63%   +<.01%     
==========================================
  Files           9        9              
  Lines         683      684       +1     
==========================================
+ Hits          660      661       +1     
  Misses         23       23
Impacted Files Coverage Δ
src/index.js 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396c5ca...ce01c68. Read the comment docs.

@exoego
Copy link
Collaborator Author

exoego commented Mar 7, 2019

@kazupon
Docs and type definition added !!

exoego
exoego commented Mar 7, 2019
View reviewed changes
decls/i18n.js Outdated
@@ -85,6 +85,8 @@ declare interface I18n {
set fallbackLocale (locale: Locale): void,
get messages (): LocaleMessages,
get dateTimeFormats (): DateTimeFormats,
get numberFormats (): NumberFormats,
Copy link
Collaborator Author

@exoego exoego Mar 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note)
I thinks numberFormats is missing and the fix is trivial, so I fixed, though it is out of scope of #193...
I can make a separate PR if it is preferrable.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you will separate it as PR. 🙏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

kazupon
kazupon reviewed Mar 8, 2019
View reviewed changes
vuepress/api/README.md Outdated Show resolved Hide resolved
@kazupon
Copy link
Owner

kazupon commented Mar 8, 2019

CI still have been failing.
Could you fix it, please?

kazupon and others added 2 commits March 8, 2019 10:41
kazupon
kazupon approved these changes Mar 8, 2019
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank for your supporting!

@kazupon kazupon merged commit 8f75b1f into kazupon:dev Mar 8, 2019
@rimiti
Copy link

rimiti commented Mar 8, 2019

Good job 🚀

@exoego exoego deleted the list-available-languages branch March 8, 2019 09:03
@tt9133github tt9133github mentioned this pull request Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@exoego @kazupon @codecov-io @rimiti