Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(src/index.js): fallbackRoot should have higher priority than formatFallbackMessages (#779) #783

Merged
merged 1 commit into from Feb 25, 2020
Merged

fix(src/index.js): fallbackRoot should have higher priority than formatFallbackMessages (#779) #783

merged 1 commit into from Feb 25, 2020

Conversation

masongzhi
Copy link
Contributor

fix #779
when formatFallbackMessages is true, _render in _warnDefault should not limited to string

@exoego
Copy link
Collaborator

exoego commented Feb 25, 2020

Thanks for opening PR.
Could you read and follow the below pull request guidelines ? (dist should not be changed).
https://github.com/kazupon/vue-i18n/blob/v8.x/CONTRIBUTING.md#pull-request-guidelines

@masongzhi
Copy link
Contributor Author

Thanks for opening PR.
Could you read and follow the below pull request guidelines ? (dist should not be changed).
https://github.com/kazupon/vue-i18n/blob/v8.x/CONTRIBUTING.md#pull-request-guidelines

Thanks, now I restore the dist directory, and rebase from kazupon/vue-i18n that test run successfully

@exoego exoego changed the title fix(src/index.js): improve formatFallbackMessages code (#779) fix(src/index.js): fallbackRoot should have higher priority than formatFallbackMessages (#779) Feb 25, 2020
exoego
exoego approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masongzhi masongzhi mentioned this pull request Feb 25, 2020
Merged
kazupon
kazupon approved these changes Feb 25, 2020
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!

@kazupon kazupon merged commit 53895b9 into kazupon:v8.x Feb 25, 2020
This was referenced Mar 18, 2020
Open
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@exoego exoego exoego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n component does not work with formatFallbackMessages
3 participants
@masongzhi @exoego @kazupon