@types: Fixed too narrow option types in n() and d() methods #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v8.x #1096 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 10 10
Lines 913 913
=======================================
Hits 881 881
Misses 32 32 Continue to review full report at Codecov.
|
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Intl.NumberFormatOptionsandIntl.DateTimeFormatOptionsvalues aren't just strings, therefore the current typeargs?: { [key: string]: string }is too narrow.Added a new overload to reflect this. I kept the old declaration for backward compatibility.
Should also fix #749