Fix wrong type for LocaleMatcher ('best-fit' to 'best fit'). #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Typescript 4.2 type definitions for Intl API was updated (microsoft/TypeScript#41880). Because of that we now have compile error when we try to compile vue-i18n in TS 4.2 RC. The reason is our wrong type definition for "localeMatcher" and "formatMatcher" properties. We had "best-fit" but it should be "best fit". This was the error when we compile vue-i18n with Typescript 4.2 RC. Now it's fixed.: > npx typescript@4.2.1-rc -p types npx: installed 1 in 3.512s types/index.d.ts:26:13 - error TS2430: Interface 'SpecificDateTimeFormatOptions' incorrectly extends interface 'DateTimeFormatOptions'. Types of property 'localeMatcher' are incompatible. Type 'LocaleMatcher | undefined' is not assignable to type '"best fit" | "lookup" | undefined'. Type '"best-fit"' is not assignable to type '"best fit" | "lookup" | undefined'. 26 interface SpecificDateTimeFormatOptions extends Intl.DateTimeFormatOptions { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Found 1 error.
kazupon
approved these changes
Feb 16, 2021
|
@kazupon typescript 4.2 got released yesterday night, can you release a new version to cover this fix? :) thanks a lot |
|
I've just released v8.23.0! |
This was referenced Mar 9, 2021
Closed
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
I was testing if my project compiles with TS 4.2 RC. and it didn't because of wrong typing of vue-i18n :(
This fixes it.
Hope this is a good PR.
from commit message:
In Typescript 4.2 type definitions for Intl API was updated (microsoft/TypeScript#41880).
Because of that we now have compile error when we try to compile vue-i18n in TS 4.2 RC.
The reason is our wrong type definition for "localeMatcher" and "formatMatcher" properties.
We had "best-fit" but it should be "best fit".
This was the error when we compile vue-i18n with Typescript 4.2 RC. Now it's fixed.: