feat: add readonly option #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! This approach allows to set if its readonly or not only at startup, right? It would be interesting if we could also add functions to enable/disable readonly mode programatically. Pretty much like @imdanielsp proposed in #74. @imdanielsp do you mind if I close your PR so we can create a new PR using both approaches (this PR and the code you proposed in #74)? |
|
Correct, @kazzkiq. It can only be set at startup. Thanks for merging. If you want me to help with enabling/disabling the code programmatically just let me know. Would it be possible to cut a release with this change so we can install it via npm? |
|
@DKirwan would you, please? As soon as we have enabling/disabling functions for this feat I will make a new release. |
|
Sure thing! |
This was referenced Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We've been using CodeFlask in a web application and came across a use case where we just wanted to display a snippet of code for users to view and/or copy to their clipboard. We thought that this use case would be common for other developers also, so decided to share our changes.
I've added a readonly option. It sets the built-in html
readonlyattribute on the textarea so it is accessible by default.