-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide on click #20
Comments
I think this is an issue about the outline of the button and balloon? I will attach a screenshot later if anyone is curious ... |
@Kivylius @yanandcoffee My concern is exactly about accessibility. To prevent the awkward outline effect, the I think its better to let the developer decide when removing it or not. If one really wants to remove the [data-balloon] {
outline: none;
} Or maybe replace the outline with a better looking effect. |
For static text is fine, but majority of people will be using this for button or links. Also what about a hiding on balloon on click |
@Kivylius It doesn't seem possible to disable this on only the balloon on-click without disabling it in general. If you do @kazzkiq I agree with you that I don't think there's any right way to solve this without hurting accessibility. I think that on mobile, people may be clicking for the tooltip, but the super thin line on Chrome is barely noticeable and purely aesthetic. On desktop, it seems more obnoxious, but it is possible for the developer to intentionally solve this with an override and for the developer to take responsibility of accessibility concerns. Here is one possible solution/suggestion for the styling of It's not possible to put a border around the little triangle from what I've tried, otherwise an overall border around the entire bubble may be a more visible style... |
Yea the blue outline might have to stay. There is another issue that we are not addressing: On hover on |
I know this is kind of an issue a little bit beside the discussion, but as the title say "Hide on click" I'm wondering how to make it hide on touch devices, because after click it stays visible. |
@almadsen That happens because when you touch the device's screen, the browser simulate the To avoid this kind of behavior in mobile browsers you can use one of those approaches: |
Also, closing this issue as it can be easily solved inside one's project by adding just a few lines of code: [data-balloon] {
outline: none;
} As this may end up in accessibility/usability issues, I do not recommend doing this without a proper visual replacement for the |
Hi I think it would make sense to hide these buttons on click as now (in chrome) there's a blue outline on click and once the button hides. Also this is the way it works in OsX and its really good UX.
This can be easily achieved by
:active
css selector. I can fork & update if you are willing to accept?@Kivylius
The text was updated successfully, but these errors were encountered: