Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Transition #53

Closed
brunoaugusto opened this issue Dec 28, 2016 · 3 comments
Closed

Optional Transition #53

brunoaugusto opened this issue Dec 28, 2016 · 3 comments
Assignees
Milestone

Comments

@brunoaugusto
Copy link

Not an issue, just something I came up while thinking about having the possibility to not have the easing animation, making it optional, so I created a new data-attribute to remove it:

[data-balloon-static]:after, [data-balloon-static]:before {
    -webkit-transition: none;
    transition: none;
}

With this if one needs the Balloon without the animation just need to add to the markup:

<button data-balloon-length="small" data-balloon="Hi." data-balloon-static>Hover me!</button>

And, of course, congratulations for the awesome work ;)

@kazzkiq
Copy link
Owner

kazzkiq commented Dec 28, 2016

Awesome idea! Would you like to send a PR with this implementation, or I could add it myself if you want to. 👍

@brunoaugusto
Copy link
Author

I'd prefer you to add it yourself because I don't have much experience with the collaborative side of GIT

@kazzkiq kazzkiq self-assigned this Jan 10, 2017
@kazzkiq kazzkiq added this to the v0.5.0 milestone Mar 21, 2017
kazzkiq added a commit that referenced this issue Aug 14, 2017
Fixing #53
kazzkiq added a commit that referenced this issue Aug 14, 2017
Fixing #53
@kazzkiq kazzkiq closed this as completed Aug 14, 2017
@kazzkiq
Copy link
Owner

kazzkiq commented Aug 14, 2017

Done.

Now you can use [data-balloon-blunt] to force tooltips without animations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants