Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sass variable defaults #52

Merged

Conversation

danieljb
Copy link
Contributor

Add !default flag to variable definitions to allow manipulation from an external SASS file.

It would then be possible to load and customize src/balloon.scss directly from another scss file:

/* customstyle.scss */
$balloon-bg:             fade-out(#F00, .25);
$balloon-base-size:      16px;

@import "~balloon-css/src/balloon";

@willylatorre
Copy link

Yes please, could this be merged?

@kazzkiq kazzkiq added this to the v0.5.0 milestone Mar 1, 2017
@kazzkiq
Copy link
Owner

kazzkiq commented Aug 8, 2017

I was afraid of accepting this and having no equivalent in LESS. But it seems LESS solution is even easier than SASS, so no changes needed.

Accepting this PR. Thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants