Skip to content
This repository has been archived by the owner on Apr 12, 2020. It is now read-only.

Router exact to pass down to Route #61

Closed
wants to merge 9 commits into from
Closed

Conversation

c0ldra1n
Copy link

Little extra, but this will enable writing:

<Router exact>
  <Route path="/">
    <Index />
  </Route>
  <Route path="/hello">
    <Hello />
  </Route>
  <Route path="*">
    <NotFound />
  </Route>
</Router>

instead of:

<Router>
  <Route exact path="/">
    <Index />
  </Route>
  <Route exact path="/hello">
    <Hello />
  </Route>
  <Route exact path="*">
    <NotFound />
  </Route>
</Router>

This is my first pull request, so please let me know if there's anything I've done wrong. Thank you! 😃

@pateketrueke
Copy link
Contributor

Interesting one, very nice first PR! 🍻

@elimisteve
Copy link

@pateketrueke Ready to merge?

@pateketrueke
Copy link
Contributor

pateketrueke commented Mar 15, 2020

Hi @elimisteve I agree, but I'm not maintainer on this repo, so I won't merge it.

cc: @kazzkiq

@kazzkiq
Copy link
Owner

kazzkiq commented Apr 12, 2020

#68

@kazzkiq kazzkiq closed this Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants