To consider: renaming the project to factory-bot #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JackDanger. Thanks for PR & suggestion however i was contacting Thoughtbot and they didn't agree to use factory_girl name for this library. That's why i've chosen factory-boy as a name. So now that they have changed the name to factory_bot i think they still wouldn't agree for me to use the same name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @kbackowski!
Thanks so much for all your hard work here. I use this library at work and I love it. Recently, Thoughtbot renamed their FactoryGirl to FactoryBot. It makes sense to me to have a Factory Bot in Ruby and another one in Javascript.
I don't mean to presume that I have the right to rename your project but I thought that, just in case you liked the idea, it might help for me to put together a PR as an example.
Again, thanks so much for your great work!