Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend python versions testing runs against #654

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

AiyionPrime
Copy link
Contributor

  • 3.10: released on 2021-10-04
  • 3.11: released on 2022-10-24

Similar to #554 two years ago.

@coveralls
Copy link

coveralls commented Jun 15, 2023

Coverage Status

coverage: 99.826%. remained the same when pulling dd2ac9a on vorausrobotik:extend_supported_versions into 440447a on kbandla:master.

@obormot
Copy link
Collaborator

obormot commented Jun 19, 2023

Suggest adding lines to setup.py similarly to the #554 referenced

@kbandla
Copy link
Owner

kbandla commented Jun 20, 2023

Is this a good time to remove 2.7?

@AiyionPrime
Copy link
Contributor Author

Imho any time is.
I read the question as to change the PR in order to remove 2.7 from the supported versions, right?

@AiyionPrime
Copy link
Contributor Author

Mhm. And the tox file has some version references I missed as well.
Update tomorrow morning.

70af119 'Extend python versions testing run against. '
- 3.10: released on 2021-10-04
- 3.11: released on 2022-10-24
- sunsetted on 2020-01-01
@AiyionPrime
Copy link
Contributor Author

I think that's it.

The previous updater missed 3.9 in tox.ini, I added that as well.
I dropped 2.7 as suggested above. Let me know if there's something missing.

@AiyionPrime
Copy link
Contributor Author

I dropped three unsupported compat scenarios and will follow up with PRs removing their artifacts after making sure they're not used anywhere.

@obormot Any idea, why build (2.7) ist still an expected step even after removing it from the workflow yml?

@obormot
Copy link
Collaborator

obormot commented Jun 21, 2023

@obormot Any idea, why build (2.7) ist still an expected step even after removing it from the workflow yml?

no clue, but try changing run-on: ubuntu-20.04 to ubuntu-latest (which doesn't include python2), and see if it helps?

to use ubuntu-latest again

reverts the workaround from kbandla#652
and resolves kbandla#651
@AiyionPrime
Copy link
Contributor Author

@obormot Python 3.5 is missing on Ubuntu20 as well.

To be specific:
Python 3.5 was sunsetted 2020-09-30
Python 3.6 was sunsetted 2021-12-23
and
Python 3.7 will be sunsetted in six days. (2023-06-27)

I'd suggest getting rid of already sunsetted versions.

- sunsetted on 2020-09-30
- sunsetted on 2021-12-23
@obormot
Copy link
Collaborator

obormot commented Jun 22, 2023

I think the reason 2.7, 3.5 and 3.6 builds are still "expected", may be branch protection rules, which are defined in the repo settings (available to @kbandla). Reference: https://github.com/orgs/community/discussions/26698

@AiyionPrime
Copy link
Contributor Author

pypy defaultet to the (unsupported) version 3.6 as per setup-python action v2.
I updated that to the latest v4, updated checkout to v3, as v4 recommends it, and set pypy to 3.7 explicitely.

We always tested for one pypy version and not all supported.
I assume that's intended?

If we want to test for more let me know and I'll update this PR accordingly.
Other than that the only apparent Issue I see is 2.7, 3.5 and 3.6 to be expected.

After @kbandla resolved that this might be good to go.

@kbandla
Copy link
Owner

kbandla commented Jun 23, 2023

updated the branch protection settings for master (removed 2.7-3.5). I will add another rule for the 2.7 branch, when we freeze it.

@AiyionPrime
Copy link
Contributor Author

Then this is ready for review;
only question remaining is the lack of additional pypy versions, which might be intended.

@obormot
Copy link
Collaborator

obormot commented Jun 23, 2023

This looks good to me. Not sure about pypy, never used it. We can update the README separately once the 2.7 support branch is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants