Fixed warn deprecation + tests raising warnings #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
warn
has been deprecated since Julia v0.7 and we should be using the@warn
macro instead.warn
is used in two locations:roots
andSplined2D
. This PR also adds tests for warnings being issued in the following.roots
when there are more roots than the maximum number of rootsSpline2D
when some internal least squares problem that is solved by the Fortran code is rank deficient. This example was harder to come by and required adjustings
carefully. Since rank-deficiency could be compiler/processor/platform dependent, it may be better to remove this test (but still keeping the changes insrc/Dierckx.jl
)