Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to lookup a notification by external key #37

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

briehl
Copy link
Member

@briehl briehl commented Dec 1, 2018

Works like this:
GET /api/V1/notification/external_key/<key>

This only works when the auth header contains a Service token, and that service was used to create the Notification. That is, the source key matches the service.

If those criteria aren't matched, returns a 404 error.

@coveralls
Copy link

coveralls commented Dec 1, 2018

Pull Request Test Coverage Report for Build 145

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.849%

Totals Coverage Status
Change from base Build 144: 0.0%
Covered Lines: 963
Relevant Lines: 1060

💛 - Coveralls

@briehl briehl merged commit 05903e6 into kbase:develop Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants