Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCT-1701 unread count #39

Merged
merged 2 commits into from
Dec 14, 2018
Merged

SCT-1701 unread count #39

merged 2 commits into from
Dec 14, 2018

Conversation

briehl
Copy link
Member

@briehl briehl commented Dec 14, 2018

Add counts of unseen notifications for each feed queried.

This changes the result structure of GET /notifications (and GET /notifications/global) from

{
    global: [note array],
    user: [note array]
}

to

{
    global: {
        feed: [note array],
        unseen: int
    },
    user: {
        feed: [note array],
        unseen: int
    }
}

@briehl
Copy link
Member Author

briehl commented Dec 14, 2018

Needs some frontend fixes before deployment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 150

  • 11 of 12 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 90.901%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeds/feeds/notification/notification_feed.py 6 7 85.71%
Totals Coverage Status
Change from base Build 149: 0.07%
Covered Lines: 969
Relevant Lines: 1066

💛 - Coveralls

@briehl briehl merged commit ea3c22d into kbase:develop Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants