Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust how the expires route works #40

Merged
merged 3 commits into from
Dec 14, 2018
Merged

Conversation

briehl
Copy link
Member

@briehl briehl commented Dec 14, 2018

Does a few things.

  1. Adjusts the POST /api/V1/notifications/expire route to require a source input and any service token.
  2. Moves the admin version of that (admins can expire any notification) to POST /admin/api/V1/notifications/expire. Requires that if external keys are used, the source must also be provided.
  3. Creates a new /admin/ route prefix, puts the global notification creation there, too, in POST /admin/api/V1/notification/global.

Not quite ready for merging, needs some docs cleanup, and more tests.

@coveralls
Copy link

coveralls commented Dec 14, 2018

Pull Request Test Coverage Report for Build 154

  • 75 of 75 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.133%

Totals Coverage Status
Change from base Build 151: 0.2%
Covered Lines: 997
Relevant Lines: 1094

💛 - Coveralls

@briehl briehl merged commit 6ab3849 into kbase:develop Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants