Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Service and App entity types #48

Merged
merged 10 commits into from
Jan 15, 2019
Merged

Conversation

briehl
Copy link
Member

@briehl briehl commented Jan 15, 2019

includes NMS/Catalog wrapper API (well, just NMS for now).

@briehl briehl merged commit 92720a1 into kbase:develop Jan 15, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 176

  • 64 of 83 (77.11%) changed or added relevant lines in 8 files are covered.
  • 12 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.4%) to 88.561%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeds/external_api/workspace.py 0 2 0.0%
feeds/entity/types/service.py 11 19 57.89%
feeds/entity/types/app.py 11 20 55.0%
Files with Coverage Reduction New Missed Lines %
feeds/entity/types/narrative.py 1 95.0%
feeds/entity/types/group.py 1 61.9%
feeds/external_api/groups.py 3 76.0%
feeds/entity/types/job.py 3 47.83%
feeds/external_api/workspace.py 4 61.73%
Totals Coverage Status
Change from base Build 175: -1.4%
Covered Lines: 1409
Relevant Lines: 1591

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants