Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little refactor for fetching global notes #50

Merged
merged 8 commits into from
Jan 15, 2019

Conversation

briehl
Copy link
Member

@briehl briehl commented Jan 15, 2019

also adds default-note-count to the configs - the default number of notifications to return. set to 100 for now.

@coveralls
Copy link

coveralls commented Jan 15, 2019

Pull Request Test Coverage Report for Build 187

  • 40 of 40 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 91.1%

Totals Coverage Status
Change from base Build 179: 1.7%
Covered Lines: 1474
Relevant Lines: 1618

💛 - Coveralls

@briehl
Copy link
Member Author

briehl commented Jan 15, 2019

...and accidentally added the next commit which has basic support for returning group feeds. Don't want to fight with Git tonight, so here it is!

@briehl briehl merged commit a0eab3b into kbase:develop Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants