This is just until the bluebird warnings are coded out of existence. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briehl
added a commit
that referenced
this pull request
Nov 6, 2015
This is just until the bluebird warnings are coded out of existence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ends up that bluebird appears to be build in develop mode, or at least the way we are including it. Perhaps the non-minified version is generated with debugging on. In any case, it uses the development settings, which includes emitting warnings. Configuring it early in the page load process (main.js) quiets it down. I'll look to see (a) how to ensure that we are including a production version and (b) whether it is easily switchable (because during development indeed it would be good to get these warnings.)
It is easy enough to switch that in our code via the Promise.config(), but there may be other implications of developer mode (but after a quick perusal I don't think so -- e.g. the library is not built differently).
So I think a kbase config for develop / production mode which is reflected in the bluebird settings but also could be handy for us as well.