Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to force tornado version under 5 in requirements.txt or change event loop code #1266

Closed
bio-boris opened this issue Mar 6, 2018 · 1 comment

Comments

@bio-boris
Copy link
Contributor

bio-boris commented Mar 6, 2018

On a fresh install of the narrative repo, the requirements.txt has a tornado requirement for tornado > 4
However, the latest tornado, v5, doesn't have io_loop anymore in the init.
You get the following error when running narratives

TypeError: __init__() got an unexpected keyword argument 'io_loop'

The workaround is to change the requirements.txt to a lower version of tornado, such as
tornado==4.5.2

Some discussion of this I found online:
bokeh/bokeh#7308

Uncaught exception in /narrative/api/kernels/c2416ccc-02db-4467-8cc7-fe9871fc46b2/channels
    Traceback (most recent call last):
      File "/workspace/narrative/narrative/narr-venv/lib/python2.7/site-packages/tornado/websocket.py", line 498, in _run_callback
        result = callback(*args, **kwargs)
      File "workspace/narrative/narrative/narr-venv/jupyter_notebook/notebook/services/kernels/handlers.py", line 260, in open
        super(ZMQChannelsHandler, self).open()
      File "workspace/narrative/narrative/narr-venv/jupyter_notebook/notebook/base/zmqhandlers.py", line 176, in open
        self.send_ping, self.ping_interval, io_loop=loop,

@briehl
Copy link
Member

briehl commented Mar 7, 2018

Thanks for finding this, and for the PR!

@briehl briehl closed this as completed Mar 7, 2018
stigtsp added a commit to stigtsp/valutakrambod that referenced this issue Jul 19, 2018
  TypeError: websocket_connect() got an unexpected keyword argument 'io_loop'

Links:

  kbase/narrative#1266
  bokeh/bokeh#7308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants