Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes filtering [KBASE-4756] #1173

Merged
merged 6 commits into from
Sep 28, 2017
Merged

Fixes filtering [KBASE-4756] #1173

merged 6 commits into from
Sep 28, 2017

Conversation

thomasoniii
Copy link
Contributor

This fixes Ticket KBASE-4756.

The filter list on the data panel only presented the type name to the user, but there are types which exist in multiple modules. As a result, filtering didn't work. If a user had a "KBaseAlpha.Foo" object, but the widget was filtering on "KBaseBeta.Foo", nothing would show up.

This change does a couple of things:

  • It removes the hardwired list of types from the widget. It was incomplete and out of date.
  • It dynamically builds a new list of types to present to the user, based upon the results of getAndRenderData. That way, the user will only see the option to filter to types that they have, instead of the massive list of all possible types.
  • The filter list includes all modules in its filtering. So it'll show "Foo" in the dropdown, but actually filter on "KBaseAlpha.Foo" and "KBaseBeta.Foo", as well as any other "Foo" types in arbitrary modules that the user may have.

There may be other tickets that reference this issue. Kbase-5051 is tangentially related.

@thomasoniii
Copy link
Contributor Author

That was way more painful to make work than it ever should've been. :-P

@briehl
Copy link
Member

briehl commented Sep 28, 2017

Looks okay to me. I think we should lend an eye toward refactoring that whole slideout, for a number of reasons. Eventually, also, that list of available types in both "My Data" and "Shared with Me" should be retrieved by a service.

But I think this will patch the immediate problem. Let's get more eyes on it on CI.

@briehl briehl merged commit 48c8c86 into develop Sep 28, 2017
@thomasoniii thomasoniii deleted the kbase-4756 branch July 9, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants