standardize cards [TASK-1158] #1186
Conversation
tiramisu24
commented
Oct 17, 2017
tiramisu24
commented
- refactor object and apps cards in narrative into separate functions
- standardize layout of cards
- move inline css into css files
…n content instead of just elipsis
| @@ -2502,6 +2549,9 @@ button.kb-data-obj { | |||
| } | |||
|
|
|||
| .kb-data-list-info { | |||
| width: 80%; | |||
| padding: 4px 0px; | |||
| border-top: 1px solid #E0E0E0;; | |||
| * var $card = new kbaseDataCard( | ||
| { | ||
| //expected values | ||
| app: app, |
There was a problem hiding this comment.
What should the values be for the various keys here? Strings? Booleans? For the date should it be ms since epoch, or a pre-formatted string?
| * creating function such as kbaseDataCard. | ||
| * | ||
| * Expected options: | ||
| * options : { |
There was a problem hiding this comment.
As above, what are the various options expected to be? String, objects, etc.?
| function KbaseCardLayout(options) { | ||
| var self = this; | ||
| //partitions | ||
| var $card = $('<div/>', { 'class': 'narrative-card-row' }); |
There was a problem hiding this comment.
Don't need the trailing forward-slash in new jquery elements.
| $ | ||
| ) { | ||
| function KbaseAppCard(entry) { | ||
| var self = entry.self; |
There was a problem hiding this comment.
What is 'entry.self' in this case? Another widget that has some attributes like a catalog client and several other options? This seems a little too dependent on passing in the calling object and expecting it to have things like the catalog client. Should probably just instantiate that here, as necessary.
| var self = this; | ||
| // add icon (logo) |
| .html($('<button class="btn btn-xs btn-default pull-right" aria-hidden="true">').append('<span class="fa fa-ellipsis-h" style="color:#888" />')); | ||
| var toggleAdvanced = function () { | ||
| if (self.selectedObject === object_info[0] && $moreRow.is(':visible')) { | ||
| .append('<tr><th>Permament Id</th><td>' + object_info[6] + '/' + object_info[0] + '/' + object_info[4] + '</td></tr>') |
There was a problem hiding this comment.
Permanent Id , not Permament (second m -> n)
| //$toggleAdvancedViewBtn.show(); | ||
|
|
||
| if ($node.is(':visible')) { | ||
| self.writtingLock = false; |
There was a problem hiding this comment.
Might be a leftover from your previous work - writtingLock -> writingLock
| @@ -90,7 +92,7 @@ define([ | |||
| options: { | |||
| title: 'Data', | |||
| loadingImage: Config.get('loading_gif'), | |||
| notLoggedInMsg: "Please log in to view a workspace.", | |||
| notLoggedInMsg: 'Please log in to view a workspace.', | |||
There was a problem hiding this comment.
This will likely never be seen, but it's a good time to fix it. Should say "Please log in to view Narrative data."
| @@ -396,11 +398,11 @@ define([ | |||
| var user = Jupyter.narrative.userId; | |||
|
|
|||
| if (!user) { | |||
There was a problem hiding this comment.
Wow, this never got updated when we moved to the new Auth platform. It tries to parse an old style auth token instead. You can safely remove this whole if statement.
There was a problem hiding this comment.
Er, the if (!user) block starting at line ~400
