PTV-682 - temp fix to Pangenome viewer #1221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peripherally related to other copy/sharing problems, I'd say this is more a problem of policy. Basically, in an original narrative, the object name and current workspace name are passed to the pangenome viewer, so it looks up the object by the "ws_name_a/obj_name_a" formulation.
In a copied narrative, due to some deep flaws in the architecture (being addressed here: #1214 ), it gets passed the current workspace name still, but now the UPA of the object from the original workspace, so it tries to build a reference as "ws_name_b/ws_id_a/obj_id_a/obj_ver_a" which is wrong.
This PR fixes a few minor issues in other modules, then "fixes" the problem in the pangenome viewer by having it interpret the object identifier passed to it. If it looks like an UPA (has a '/' character), it gets treated as such, otherwise, it builds the reference with the workspace name and object name.
The Real Fix will come later from the other copy/sharing fixes, but this'll be enough to deal with the ticket as is.