Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KBASE-5405] bug fixes #1232

Merged
merged 6 commits into from
Jan 12, 2018
Merged

[KBASE-5405] bug fixes #1232

merged 6 commits into from
Jan 12, 2018

Conversation

tiramisu24
Copy link
Contributor

-no longer crashes when two lines are the same
-scrolls up and down during app run pause
-line numbers are unselectable when copying
-x axis scroll removed (border that looks like scroll left in)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 12.54% when pulling 37f3134 on tiramisu24:develop into 1463033 on kbase:develop.

Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seeing a missing semicolon. Otherwise looks fine.


doStopPlayLogs();
var currentLine = currentSection ? currentSection : Number(model.getItem('currentLine')),
lastLine = model.getItem('lastLine'),
$panel = $(ui.getElements('panel')[0])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e545b3c on tiramisu24:develop into ** on kbase:develop**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants