Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct to image #1235

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Struct to image #1235

merged 3 commits into from
Jan 25, 2018

Conversation

JamesJeffryes
Copy link
Contributor

Some minor tweaks to the modeling viewers:

  1. If there is no enzyme data for a reaction, the entire viewer won't crash
  2. Compound names in reactions will link to their respective compound pages

@coveralls
Copy link

coveralls commented Jan 13, 2018

Coverage Status

Coverage increased (+0.05%) to 12.589% when pulling 7001467 on JamesJeffryes:struct_to_image into d021356 on kbase:develop.

Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to minimize console.log messages, otherwise, looks good.

@@ -242,6 +242,7 @@ function KBaseFBA_FBAModel(modeltabs) {

this.ReactionTab = function (info) {
var rxn = self.rxnhash[info.id];
console.log(rxn)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably isn't necessary, outside of testing.

@briehl briehl merged commit debf2eb into kbase:develop Jan 25, 2018
@JamesJeffryes JamesJeffryes deleted the struct_to_image branch May 2, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants