add report icon to data panel data object toolbar [SCT-930] #1321
Conversation
- adds call to workspace to fetch referencing objects when gathering object info - adds menu button to toolbar: enabled if a report is available, disabled otherwise - refactored a bit to move button creation out of main toolbar method - refactored buttons to use the (already generated) object-ified object info - self -> _this; self is a global variable (property of window)
|
|
||
| var reportRegex = /^KBaseReport.Report-/; | ||
|
|
||
| return narrativeService.callFunc('list_objects_with_sets', [{ |
There was a problem hiding this comment.
What does this do, exactly? It looks like you're stitching in to the Data Panel populator and looking up everything that references each object, and filtering for reports? That should either just be part of the NarrativeService call. Or, to make it faster, just find the report when the it's requested. In a large narrative, this might take forever.
Also, copied objects (i.e. everything in a copied narrative) lose that link. You can find it by tracing back up the copy chain, but that's also something that shouldn't be applied to every object in a Narrative, and only on request.
There was a problem hiding this comment.
I'm working on a function in NarrativeService right now that should do what you need.
|
Yes, you got it. I should have added a note, but presumed because of the earlier conversation that you might pick up the NS side of it if you had time, as you have. Otherwise, it works well enough as is to iterate upon. |
|
I'll have to pick this up later in the weekend. Got a function mostly there, but not entirely tested. In the meantime, would this work? Think anything else would be helpful? I figure the service itself should return a list of reports (if there's more than one), and the interface can do with that what it wants. |
|
Took a look at the NS changes finally. Looks like it covers the needs just fine ... |
|
Hey, before merging this, would you mind looking at (and maybe merging) #1323 ? I suspect lingering nonsense with PhantomJS is one of the causes of our recent testing woes. |
- also report query is not run until the data list detail opens.
No description provided.