Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAUP-235 Update Integration Testing ADR #1862

Merged
merged 3 commits into from
Oct 21, 2020
Merged

DATAUP-235 Update Integration Testing ADR #1862

merged 3 commits into from
Oct 21, 2020

Conversation

eamahanna
Copy link
Contributor

Description of PR purpose/changes

This ADR was updated to reflect the recent decision to use selenium webdriver as the integration testing library in the narrative repo.

Jira Ticket / Issue

https://kbase-jira.atlassian.net/jira/software/projects/DATAUP/boards/57

  • Added the Jira Ticket to the title of the PR e.g. (DATAUP-69 Adds a PR template)

@coveralls
Copy link

coveralls commented Oct 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 16.327% when pulling 8f358fc on DATAUP-235-update-ADR-integration-testing into a59fd36 on develop.

leia-sefkin
leia-sefkin approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@leia-sefkin leia-sefkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - only small comment would be whether we want to expand on the iframe support matter further as it was key to making the decision (from what i understand)

ialarmedalien
ialarmedalien approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

briehl
briehl approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@briehl briehl merged commit b3bc999 into develop Oct 21, 2020
@briehl briehl deleted the DATAUP-235-update-ADR-integration-testing branch October 21, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialarmedalien ialarmedalien ialarmedalien approved these changes

@bio-boris bio-boris bio-boris approved these changes

@briehl briehl briehl approved these changes

@leia-sefkin leia-sefkin leia-sefkin approved these changes

@dakotablair dakotablair Awaiting requested review from dakotablair

@eapearson eapearson Awaiting requested review from eapearson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eamahanna @coveralls @ialarmedalien @bio-boris @briehl @leia-sefkin