DATAUP-246: css to sass: css cleanup, part 1 #1867

ialarmedalien · 2020-10-15T18:05:22Z

Description of PR purpose/changes

Cleaning up the existing CSS files prior to conversion to SCSS.

Splitting this work up into small chunks to make it less of a nightmare to PR.

First commit:

there was a small amount of css in some appCell-specific files; since it was namespaced nicely, I moved consolidated it all into the existing appCell.css file. Fixed up errors in appCell.css and reworked the css to combine duplicated statements.

Second commit:

fixed more errors in existing css files; still have a couple more to do, but these will go in a separate PR.

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-246

Testing Instructions

Details for how to test the PR:

Tests pass in travis and locally
Changes available by spinning up a local narrative and clicking around to look at parts of the UI.

Dev Checklist:

My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation - N/A
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works - N/A
New and existing unit tests pass locally with my changes

Updating Version and Release Notes (if applicable)

N/A

ialarmedalien · 2020-10-15T18:08:41Z

nbextensions/advancedViewCell/styles/main.css

-    Author     : erik
-*/
-
-.kb-advanced-view-cell .kb-panel-container[data-element=parameters-group] > div.panel-collapse > .panel-body {


moved this into appCell.css

ialarmedalien · 2020-10-15T18:09:21Z

nbextensions/advancedViewCell/main.js

    'kb_service/utils',
    'kb_service/client/workspace',
    'css!kbase/css/appCell.css',
-    'css!./styles/main.css',


consolidated the styles in ./styles/main.css into kbase/css/appCell.css and removed /styles/main.css

ialarmedalien · 2020-10-15T18:10:04Z

nbextensions/appCell2/main.js

@@ -26,7 +26,6 @@ define([
    'kb_service/client/workspace',
    './appCell',
    'css!kbase/css/appCell.css',
-    'css!./styles/main.css',


file has no css content => deleted

ialarmedalien · 2020-10-15T18:10:58Z

nbextensions/editorCell/styles/main.css

@@ -1,419 +0,0 @@
-/* Wrapper class


Moved all these styles into appCell.css. The majority mimic styles that were already in that file.

ialarmedalien · 2020-10-15T18:12:13Z

kbase-extension/static/kbase/css/appCell.css

@@ -7,24 +7,30 @@
    font-family: 'Oxygen', sans-serif;
 }

-.kb-app-cell .kb-app-warning {
+.kb-app-cell .kb-app-warning,


The majority of new content in this file comes from editor cell css file, and mimics the existing .kb-app-cell styles.

ialarmedalien · 2020-10-15T18:15:10Z

kbase-extension/static/kbase/css/buttons.css

-}
-*/
-
-.btn.kb-flat-btn:hover {


overwritten in next declaration. doh!

ialarmedalien · 2020-10-15T18:15:26Z

kbase-extension/static/kbase/css/kbaseJobLog.css

-    text-decoration-style: solid;
-    text-decoration-color: red;


ialarmedalien · 2020-10-15T18:16:08Z

kbase-extension/static/kbase/custom/custom.css


 /* margin left doesn't really seeem to play well */

 .btn-toolbar {
    margin-left: 0;
-    padding-left: -5px;


cannot use negative units for padding

ialarmedalien · 2020-10-15T18:16:40Z

nbextensions/editorCell/styles/old.css

@@ -1,181 +0,0 @@
-/* Wrapper class 


this file is unused

ialarmedalien · 2020-10-15T18:18:29Z

kbase-extension/static/kbase/css/appCell.css

    color: #FFF;
    background-color: rgb(209, 82, 65);
    border-bottom: 6px rgb(209, 82, 65) solid;
    margin-bottom: 0;
 }

-.btn.kb-app-cell-btn.btn-danger.active:hover {


repeated two stanzas below

ialarmedalien · 2020-10-15T18:20:22Z

kbase-extension/static/kbase/css/appCell.css

-    margin-left: 0px;
-    margin-right: 4px;
-    font-family: "FontAwesome";
-    font-style: normal;
-    font-weight: normal;
-    font-size: 90%;
-    width: 12px;
-    color: silver;
-    line-height: 1;
-    vertical-align: baseline;
-    content: "\f078 ";
-}


identical to .kb-app-cell .panel-title > [data-toggle="collapse"] below

coveralls · 2020-10-15T18:21:57Z

Coverage remained the same at 16.961% when pulling 6ae2c7e on DATAUP-246_css_to_sass-css_cleanup into d78cc01 on truss.

leia-sefkin

Oh dang what a satisfying cleanup pass already! So many xcolor and xmargin and xelement_that_somedev_was_too_lazy_to_properly_remove :P

Thanks for all the comments it helps to review all of these changes. Looks good overall to me

…n/static/kbase/css/appCell.css` Validate appCell.css and fix errors

…pHelper.css, buttons.css, contigBrowserStyles.css, kbaseJobLog.css, kbaseNotify.css, kbaseStylesheet.css, and kbaseTour.css. Also fixed errors in kbase-extension/static/kbase/custom/custom.css.

sonarcloud · 2020-10-15T23:28:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

ialarmedalien requested review from briehl, bio-boris, eamahanna and leia-sefkin October 15, 2020 18:05

ialarmedalien self-assigned this Oct 15, 2020

ialarmedalien added the enhancement label Oct 15, 2020

ialarmedalien commented Oct 15, 2020

View reviewed changes

kbase-extension/static/kbase/css/buttons.css

}

*/

.btn.kb-flat-btn:hover {

Copy link

Collaborator Author

ialarmedalien Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overwritten in next declaration. doh!

ialarmedalien commented Oct 15, 2020

View reviewed changes

nbextensions/editorCell/styles/old.css

@@ -1,181 +0,0 @@

/* Wrapper class

Copy link

Collaborator Author

ialarmedalien Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is unused

ialarmedalien commented Oct 15, 2020

View reviewed changes

leia-sefkin approved these changes Oct 15, 2020

View reviewed changes

ialarmedalien force-pushed the DATAUP-246_css_to_sass-css_cleanup branch from dfe05ab to d7a2779 Compare October 15, 2020 23:23

ialarmedalien added 2 commits October 15, 2020 16:24

Move css out of nbextensions dir and consolidate in `kbase-extensio…

074f7ae

…n/static/kbase/css/appCell.css` Validate appCell.css and fix errors

Fixing css errors in kbase-extension/static/kbase/css/ files bootstra…

6486a6a

…pHelper.css, buttons.css, contigBrowserStyles.css, kbaseJobLog.css, kbaseNotify.css, kbaseStylesheet.css, and kbaseTour.css. Also fixed errors in kbase-extension/static/kbase/custom/custom.css.

ialarmedalien force-pushed the DATAUP-246_css_to_sass-css_cleanup branch from d7a2779 to 6486a6a Compare October 15, 2020 23:24

ialarmedalien merged commit 6c45a0b into truss Oct 16, 2020

ialarmedalien deleted the DATAUP-246_css_to_sass-css_cleanup branch October 16, 2020 13:18

ialarmedalien restored the DATAUP-246_css_to_sass-css_cleanup branch October 16, 2020 18:15

ialarmedalien mentioned this pull request Oct 16, 2020

Revert "DATAUP-246: css to sass: css cleanup, part 1" #1869

Merged

ialarmedalien deleted the DATAUP-246_css_to_sass-css_cleanup branch November 25, 2020 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DATAUP-246: css to sass: css cleanup, part 1 #1867

DATAUP-246: css to sass: css cleanup, part 1 #1867

ialarmedalien commented Oct 15, 2020 •

edited

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020 •

edited

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020

ialarmedalien Oct 15, 2020 •

edited

ialarmedalien Oct 15, 2020

coveralls commented Oct 15, 2020 •

edited

leia-sefkin left a comment

sonarcloud bot commented Oct 15, 2020

DATAUP-246: css to sass: css cleanup, part 1 #1867

DATAUP-246: css to sass: css cleanup, part 1 #1867

Conversation

ialarmedalien commented Oct 15, 2020 • edited

Description of PR purpose/changes

Jira Ticket / Issue

Testing Instructions

Dev Checklist:

Updating Version and Release Notes (if applicable)

Choose a reason for hiding this comment

ialarmedalien Oct 15, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ialarmedalien Oct 15, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Oct 15, 2020 • edited

leia-sefkin left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 15, 2020

ialarmedalien commented Oct 15, 2020 •

edited

ialarmedalien Oct 15, 2020 •

edited

ialarmedalien Oct 15, 2020 •

edited

coveralls commented Oct 15, 2020 •

edited