Dataup 224 add check boxes to staging

[leia-sefkin]

Description of PR purpose/changes

Finally ready in all of its glory - multi-select checkboxes. Phew! It's been a wild ride - thanks for coming along y'all

Requirements:

• Make file type selection box red for each uploaded file when a file type has NOT been selected. (Without an autodetect implemented, all files will show a red file type selector by default). The checkbox for that row is also default disabled.

• Until any file type is selected the check all checkbox is disabled

• When a file type is selected for that row, the red box color goes back to the original (grey) color and checkboxes are enabled.

• Import Selected button is disabled until a file is selected.

• On selection of file(s) and clicking import selected new importers will be kicked off. One for each file.

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-224

Testing Instructions

• Tests pass locally, to isolate run stagingAreaViewer-spec.js
• Changes available by spinning up a local narrative:
• Navigate to the data import tab
• Make sure you have at least one file added
• Before selecting data type the dropdown should be red placeholder text "Select a type"
• On clicking in the border and text color should change to black
• If you click away without selecting a type text color should return to placeholder state
• If you select a type the text and border should stay black
• Checkboxes should be enabled
• On checking a checkbox the import selected button should become enabled

Dev Checklist:

• My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[coveralls]

Coverage decreased (-0.4%) to 16.582% when pulling 813e8b9 on DATAUP-224-add-check-boxes-to-staging into a30f5aa on truss.

[eamahanna]

I agree with the comments AJ left. Once those changes are made and I can run the branch locally (when things are up and running), I am happy to approve :)

[briehl]

I have a couple pretty picky points, but this looks great! Nice work wrangling Select2!

[codecov]

Codecov Report

Merging #1874 into truss will increase coverage by 1.04%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##            truss    #1874      +/-   ##
==========================================
+ Coverage   12.69%   13.74%   +1.04%     
==========================================
  Files         405      414       +9     
  Lines       43739    44756    +1017     
==========================================
+ Hits         5551     6150     +599     
- Misses      38188    38606     +418     

Impacted Files	Coverage Δ
...idgets/narrative_core/kbaseNarrativeManagePanel.js	0.53% <ø> (+<0.01%)	⬆️
kbase-extension/static/kbase/js/kbaseNarrative.js	39.57% <37.38%> (ø)
...widgets/narrative_core/upload/stagingAreaViewer.js	63.05% <54.94%> (+0.88%)	⬆️
...js/widgets/appWidgets2/input/select2ObjectInput.js	80.12% <0.00%> (-0.63%)	⬇️
...xtension/static/kbase/js/kbaseNarrativePrestart.js	45.63% <0.00%> (ø)
kbase-extension/static/kbase/js/narrativeConfig.js	67.69% <0.00%> (ø)
...ension/static/kbase/js/widgetMaxWidthCorrection.js	16.66% <0.00%> (ø)
kbase-extension/static/kbase/js/tour.js	46.00% <0.00%> (ø)
kbase-extension/static/kbase/js/kbwidget.js	46.66% <0.00%> (ø)
kbase-extension/static/kbase/js/narrativeLogin.js	61.45% <0.00%> (ø)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7539b8d...69b2bba. Read the comment docs.

[leia-sefkin]

this is one part of the tests i couldn't quite figure out.

when i set the dropdown value above on line 293, this triggers the select2:select event in stagingAreaViewer on 491. i am able to confirm this event gets fired, as the above check to make sure the checkbox input is enabled works.

however for some reason the updates to the header "select all" checkbox don't get applied, even though they are in the same method call, on line 506.

the test still "works" because the element exists, but it's not really a fair test of the functionality that we are expecting (that the checkbox should be enabled). any advice is welcome

[leia-sefkin]

Note that Codacy is complaining about having an !important property on one of my css declarations, but that's needed to override a dataTables inline css style

[eamahanna]

LGTM, nice job.

[briehl]

Looks great! Nice work!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 1 Security Hotspot to review)
0 Code Smells

No Coverage information
0.0% Duplication