-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAUP-246: error pages #1887
DATAUP-246: error pages #1887
Conversation
kbase-extension/static/errorMain.js
Outdated
@@ -21,7 +21,7 @@ require([ | |||
return Login.init($('#signin-button'), true); | |||
}) | |||
.then(function () { | |||
let statusCode = document.getElementsByClassName('error')[0].getAttribute('data-code'); | |||
let statusCode = document.getElementById('error_container').getAttribute('data-code'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessing by the element ID instead of the class, since I changed the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statusCode doesn't change, so it can be const.
/* | ||
To change this license header, choose License Headers in Project Properties. | ||
To change this template file, choose Tools | Templates | ||
and open the template in the editor. | ||
*/ | ||
|
||
/* | ||
Created on : Jul 14, 2016, 2:31:08 PM | ||
Author : erik | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unneeded
font-weight: bold; | ||
font-size: 200%; | ||
line-height: 1.5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all a bit random and horrible, but leaving it as-is for now. When the typography is sorted out, it can be edited to be more uniform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me.
kbase-extension/static/errorMain.js
Outdated
@@ -21,7 +21,7 @@ require([ | |||
return Login.init($('#signin-button'), true); | |||
}) | |||
.then(function () { | |||
let statusCode = document.getElementsByClassName('error')[0].getAttribute('data-code'); | |||
let statusCode = document.getElementById('error_container').getAttribute('data-code'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statusCode doesn't change, so it can be const.
DATAUP-269: fix add new cell buttons
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description of PR purpose/changes
Cleaning up error template pages and moving the css to a separate file
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-246
Testing Instructions
... plus any others that you can generate!
Dev Checklist: