DATAUP-246: error pages #1887
Merged
DATAUP-246: error pages #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialarmedalien
requested review from
briehl,
bio-boris,
eamahanna and
leia-sefkin
ialarmedalien
commented
Oct 23, 2020
kbase-extension/static/errorMain.js
Outdated
| @@ -21,7 +21,7 @@ require([ | |||
| return Login.init($('#signin-button'), true); | |||
| }) | |||
| .then(function () { | |||
| let statusCode = document.getElementsByClassName('error')[0].getAttribute('data-code'); | |||
| let statusCode = document.getElementById('error_container').getAttribute('data-code'); | |||
There was a problem hiding this comment.
accessing by the element ID instead of the class, since I changed the class
There was a problem hiding this comment.
statusCode doesn't change, so it can be const.
ialarmedalien
commented
Oct 23, 2020
Comment on lines
-1
to
-11
| /* | ||
| To change this license header, choose License Headers in Project Properties. | ||
| To change this template file, choose Tools | Templates | ||
| and open the template in the editor. | ||
| */ | ||
|
|
||
| /* | ||
| Created on : Jul 14, 2016, 2:31:08 PM | ||
| Author : erik | ||
| */ | ||
|
|
ialarmedalien
commented
Oct 23, 2020
Comment on lines
+14
to
+16
| font-weight: bold; | ||
| font-size: 200%; | ||
| line-height: 1.5; |
There was a problem hiding this comment.
This is all a bit random and horrible, but leaving it as-is for now. When the typography is sorted out, it can be edited to be more uniform.
11 tasks
briehl
approved these changes
Oct 23, 2020
kbase-extension/static/errorMain.js
Outdated
| @@ -21,7 +21,7 @@ require([ | |||
| return Login.init($('#signin-button'), true); | |||
| }) | |||
| .then(function () { | |||
| let statusCode = document.getElementsByClassName('error')[0].getAttribute('data-code'); | |||
| let statusCode = document.getElementById('error_container').getAttribute('data-code'); | |||
There was a problem hiding this comment.
statusCode doesn't change, so it can be const.
DATAUP-269: fix add new cell buttons
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
Cleaning up error template pages and moving the css to a separate file
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-246
Testing Instructions
... plus any others that you can generate!
Dev Checklist: