-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split test functions in gha #2321
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## develop #2321 +/- ##
===========================================
+ Coverage 12.90% 12.91% +0.01%
===========================================
Files 415 415
Lines 44581 44581
===========================================
+ Hits 5752 5757 +5
+ Misses 38829 38824 -5
Continue to review full report at Codecov.
|
Are you already on the case of the codecov failure? PR looks fine otherwise. |
Yeah, I'm on it. It's strange. I think it's a secrets issue, but I'm not sure how. I also noticed that the Python coverage file setup is wrong - it's making the wrong file! This led me down a little rabbit hole of switching from nosetests -> pytest in the Python stack, but that should probably be a different PR. Happily, that changeover was pretty much just swapping one for the other. |
Looks like it's a new issue with Codecov. I still want to go through with fixing the Python coverage stuff. But I'll do that in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look fine; with any luck the codecov people will fix their side of the coverage problem so that the unit test workflow will pass.
Description of PR purpose/changes
Separates the test actions into unit test and integration test runs, so they can be more easily checked to see what passes and what fails. It maybe makes things take a little longer as the app has to get built multiple times, but I think it'll be helpful for seeing at a glance what's failing.
This came up from seeing a new batch of
dependabot
PRs which all failed miserably. This is really due todependabot
using a separate fork for submitting PRs - so another option might be to have the integration tests skip / fail immediately if there's no token available. Right now, they continue and just time out all over the place as they're running tokenless. The unit tests should be fine without authentication, and in fact, that's preferred.Jira Ticket / Issue
e.g. https://kbase-jira.atlassian.net/browse/DATAUP-X
DATAUP-69 Adds a PR template
)Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)