Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object spread syntax that esprima 4.0.1 doesn't like #2657

Conversation

charleshtrenholm
Copy link
Contributor

Description of PR purpose/changes

  • Please include a summary of the change and which issue is fixed.
  • fixes unresolved issue with esprima that can be found here
  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-X

  • Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • (Python) I have run Black and Flake8 on changed Python code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #2657 (b3a0380) into dynamic-dropdown-changes (1e0bd17) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           dynamic-dropdown-changes    #2657      +/-   ##
============================================================
- Coverage                     25.17%   25.11%   -0.06%     
============================================================
  Files                           505      505              
  Lines                         51833    51841       +8     
============================================================
- Hits                          13049    13021      -28     
- Misses                        38784    38820      +36     
Impacted Files Coverage Δ
.../widgets/appWidgets2/input/dynamicDropdownInput.js 45.50% <0.00%> (-2.15%) ⬇️
...tatic/kbase/js/widgets/kbaseAuthenticatedWidget.js 26.66% <0.00%> (-26.67%) ⬇️
kbase-extension/static/kbase/js/kbwidget.js 36.36% <0.00%> (-5.20%) ⬇️
.../widgets/function_output/samples/kbaseSampleSet.js 92.00% <0.00%> (-1.34%) ⬇️
nbextensions/bulkImportCell/bulkImportCell.js 84.85% <0.00%> (-1.27%) ⬇️
kbase-extension/static/kbase/js/common/props.js 72.83% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d7cbf...b3a0380. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@briehl briehl merged commit c54c068 into kbase:dynamic-dropdown-changes Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants