Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose request.sequence to Python #61

Closed
wants to merge 1 commit into from
Closed

Expose request.sequence to Python #61

wants to merge 1 commit into from

Conversation

meawoppl
Copy link
Contributor

@meawoppl meawoppl commented Dec 6, 2022

Not much to it!

kbingham
kbingham reviewed Dec 6, 2022
View reviewed changes
Copy link
Owner

@kbingham kbingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but to be merged, it needs to be sent to the libcamera mailing list, following the contributing requirements and have two reviews.

@meawoppl
Copy link
Contributor Author

meawoppl commented Dec 6, 2022

Sent an email doing my best to follow the process there. LMK how I did!

@meawoppl
py: Expose request::sequence to python bindings
ee56703 
Signed Off By Matthew Goodman <meawoppl@gmail.com>
@meawoppl
Copy link
Contributor Author

Thanks for pulling this in upstream.

@meawoppl meawoppl closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbingham kbingham kbingham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meawoppl @kbingham