Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure was modified of $Git_Tests['Git'] #3

Merged
merged 1 commit into from
May 30, 2012
Merged

Conversation

fitorec
Copy link
Contributor

@fitorec fitorec commented May 29, 2012

Maybe another option would:

<?php

$Git_Tests = array(
    'Git' => function() {
        $repo = new GitRepo();
        return $repo->test_git()? array(0, "Git was located and tested successfully") :
                            array(1, "Git could not be found at the default location");
    },  

 Author: @fitorec <chanerec@gmail.com>
---------------------------------------------------------------------
 test/test-suite.php |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
kbjr added a commit that referenced this pull request May 30, 2012
Structure was modified of $Git_Tests['Git']
@kbjr kbjr merged commit 725af21 into kbjr:master May 30, 2012
@fitorec
Copy link
Contributor Author

fitorec commented Jun 1, 2012

I'm thinking it's a good idea to initialize all arrays to null.

@fitorec
Copy link
Contributor Author

fitorec commented Jun 1, 2012

All arrays $Git_Tests

@kbjr
Copy link
Owner

kbjr commented Jun 1, 2012

It's been quite a while since I wrote this, so I am reacquainting myself with this code as I go...

I agree, it does seem more efficient. I will change that in a minute..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants