Support checking for offline updates against a local registry #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of town this weekend, I can try the changes on Monday. |
|
This doesn't seem to change the behaviour for me. Still getting the same error. |
|
This unblocks using cargo-outdated in CI for us, any chance we can get this merged? |
|
@anp Thanks for this! I'd like to make sure the lint and format checks pass could you try to push a commit to trigger the checks (might have to rebase ontop of the latest upstream changes). I'm not sure why they didn't trigger here. |
tmandry
force-pushed
the
local-registry
branch
from
5e8c230
to
ca46b17
Compare
|
Branch was force pushed, but needs approval for running workflows: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
Useful for testing against a local registry and ensuring crates.io isn't accessed.
Loading them directly from SourceId::load fails to account for registry override configuration, causing a panic when querying for updates for crates that aren't on crates.io. Change-Id: I5e47f8f69b78a70db689b2f755a889cf942d3268
kbknapp
force-pushed
the
local-registry
branch
from
ca46b17
to
2a5bf77
Compare
|
Rebased on the latest master. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
TempProject::find_updatescallsSourceId::loadto get a registry for queries, but that function doesn't pay attention to registry overrides in the config.SourceConfigMap::loaddoes take them into account, and everything else seems to work fine once the override is correctly configured.I tested this by adding
127.0.0.1 localhostto/etc/hoststo prevent cargo from accessing the servers.I intend to add a more thorough test for CI here but wanted to make sure this seems like the right fix to maintainers beforehand.It looks like CI isn't running much in the way of tests so I'm hesitant to build out a whole harness just for this, let me know what your preference is.EDIT: For context, the motivation here is to allow isolated CI testing of a crate update workflow tool without taking a dependency on crates.io itself.