New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use serde macro via serde crate instead of serde_derive #365

Merged

kbknapp merged 2 commits into kbknapp:master from tottoto:remove-serde-derive-dependency

Nov 2, 2023

Contributor

tottoto commented Aug 20, 2023

serde's macros could be used via serde crate as its derive feature is enabled.


          use serde macro via serde crate instead of serde_derive

a5e6e47

Owner

kbknapp commented Nov 1, 2023

NOTE
I'd actually like to have gone the other direction (remove the derive feature of serde and use serde_derive directly). However, in cargo-oudated's case it doesn't matter as we already use the derive feature and removing it doesn't change anything due to other dependencies.

I'm good with this change as is - we can change later if needed or if we find a way to compile serde and serde_derive in parallel in the future.


          Merge branch 'master' into remove-serde-derive-dependency

kbknapp merged commit 94b2bab into kbknapp:master

12 of 13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment