This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Make more fields public #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @yberreby (yo-bot has picked a reviewer for you, use r? to override) |
|
r? @kbknapp |
|
@aidanhs sounds good! Yeah those types that should be Since this is still pre 1.0 simply bumping the minor is all that needs to be done in order to make a breaking change. @homu r+ |
|
📌 Commit 7b54a33 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jun 20, 2016
Make more fields public This PR makes all fields in responses public - there's not much point in having them if they can't be used! On the other hand, I was considering making a PR to convert a bunch of things to better types (e.g. f64 id to u64), which would be less of a breaking change (slightly) if these fields stayed private for now. Thoughts @kbknapp ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all fields in responses public - there's not much point in having them if they can't be used!
On the other hand, I was considering making a PR to convert a bunch of things to better types (e.g. f64 id to u64), which would be less of a breaking change (slightly) if these fields stayed private for now.
Thoughts @kbknapp ?